The GitHub Actions job "Required Checks" on texera.git/main has succeeded. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: 4c982a7a8abba119b326b19456f4ef7fda78f059 / Suryaa Charan <[email protected]> chore: ignore symlinks at the generated proto and node_modules paths (#8887) ### What changes were proposed in this PR? Two `.gitignore` patterns end in `/`, which only matches directories: ``` amber/src/main/python/proto/ **/node_modules/ ``` A symlink at either path isn't ignored. This is easy to hit when you run tests in a second worktree and symlink the generated protos or `node_modules` from your main checkout instead of regenerating them. A `git add -A` then commits the symlink. That happened to me in #8769: the symlink got committed, and CI's `bin/python-proto-gen.sh` failed with `mkdir: cannot create directory '.../amber/src/main/python/proto': File exists`, so every job stopped before running tests. This drops the trailing slash on both lines, so files, symlinks and directories at those paths are all ignored. ### Any related issues, documentation, discussions? Found while working on #8769. ### How was this PR tested? In a scratch repo with a symlink at `amber/src/main/python/proto` and at `agent-service/node_modules`: - old patterns: both symlinks show up in `git status` as untracked - new patterns: both are ignored Real directories at those paths are still ignored, since a pattern without a trailing slash matches directories too. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) Co-authored-by: suryaacharan <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/37653661886 With regards, GitHub Actions via GitBox
