TEZ-3639. Tez UI: Footer pagination is improper in landing page (sree)
Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/57119a51 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/57119a51 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/57119a51 Branch: refs/heads/TEZ-1190 Commit: 57119a5119637c1f9f356216bcc155bb238d01ec Parents: bdc0ee9 Author: Sreenath Somarajapuram <[email protected]> Authored: Tue Feb 28 14:47:23 2017 +0530 Committer: Sreenath Somarajapuram <[email protected]> Committed: Tue Feb 28 14:47:23 2017 +0530 ---------------------------------------------------------------------- CHANGES.txt | 1 + tez-ui/src/main/webapp/app/controllers/home/index.js | 1 + tez-ui/src/main/webapp/app/controllers/home/queries.js | 1 + tez-ui/src/main/webapp/app/templates/home/index.hbs | 1 + tez-ui/src/main/webapp/app/templates/home/queries.hbs | 1 + tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js | 3 ++- .../src/main/webapp/tests/unit/controllers/home/queries-test.js | 1 + 7 files changed, 8 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 88b0b98..8bb3749 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -205,6 +205,7 @@ ALL CHANGES: TEZ-3629. Tez UI: Enable the UI to display log links from LLAP TEZ-3626. Tez UI: First Task Start Time & Last Task Finish Time values are showing up incorrectly TEZ-3630. Tez UI: Use DAG status for controlling auto-refresh polling + TEZ-3639. Tez UI: Footer pagination is improper in landing page Release 0.8.5: Unreleased http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/app/controllers/home/index.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/controllers/home/index.js b/tez-ui/src/main/webapp/app/controllers/home/index.js index 61e7a9f..9194fd6 100644 --- a/tez-ui/src/main/webapp/app/controllers/home/index.js +++ b/tez-ui/src/main/webapp/app/controllers/home/index.js @@ -49,6 +49,7 @@ export default TableController.extend({ loadingMore: false, headerComponentNames: ['dags-page-search', 'table-controls', 'pagination-ui'], + footerComponentNames: ['pagination-ui'], _definition: TableDefinition.create(), // Using computed, as observer won't fire if the property is not used http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/app/controllers/home/queries.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/controllers/home/queries.js b/tez-ui/src/main/webapp/app/controllers/home/queries.js index 49da719..57b3964 100644 --- a/tez-ui/src/main/webapp/app/controllers/home/queries.js +++ b/tez-ui/src/main/webapp/app/controllers/home/queries.js @@ -50,6 +50,7 @@ export default TableController.extend({ loadingMore: false, headerComponentNames: ['queries-page-search', 'table-controls', 'pagination-ui'], + footerComponentNames: ['pagination-ui'], _definition: TableDefinition.create(), // Using computed, as observer won't fire if the property is not used http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/app/templates/home/index.hbs ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/templates/home/index.hbs b/tez-ui/src/main/webapp/app/templates/home/index.hbs index bf4319c..fe18266 100644 --- a/tez-ui/src/main/webapp/app/templates/home/index.hbs +++ b/tez-ui/src/main/webapp/app/templates/home/index.hbs @@ -25,6 +25,7 @@ classNames="all-dags-table" headerComponentNames=headerComponentNames + footerComponentNames=footerComponentNames definition=definition enableSort=false http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/app/templates/home/queries.hbs ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/templates/home/queries.hbs b/tez-ui/src/main/webapp/app/templates/home/queries.hbs index 22e60e3..db38f96 100644 --- a/tez-ui/src/main/webapp/app/templates/home/queries.hbs +++ b/tez-ui/src/main/webapp/app/templates/home/queries.hbs @@ -25,6 +25,7 @@ classNames="all-queries-table" headerComponentNames=headerComponentNames + footerComponentNames=footerComponentNames definition=definition enableSort=false http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js b/tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js index 810c8c9..579cc76 100644 --- a/tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js +++ b/tez-ui/src/main/webapp/tests/unit/controllers/home/index-test.js @@ -26,7 +26,7 @@ moduleFor('controller:home/index', 'Unit | Controller | home/index', { }); test('Basic creation test', function(assert) { - assert.expect(2 + 12); + assert.expect(2 + 4 + 1 + 4 + 2 + 2); let controller = this.subject({ initVisibleColumns: Ember.K, @@ -47,6 +47,7 @@ test('Basic creation test', function(assert) { assert.ok(controller.queryParams); assert.ok(controller.headerComponentNames); assert.equal(controller.headerComponentNames.length, 3); + assert.equal(controller.footerComponentNames.length, 1); assert.ok(controller._definition); assert.ok(controller.definition); http://git-wip-us.apache.org/repos/asf/tez/blob/57119a51/tez-ui/src/main/webapp/tests/unit/controllers/home/queries-test.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/tests/unit/controllers/home/queries-test.js b/tez-ui/src/main/webapp/tests/unit/controllers/home/queries-test.js index ccec36c..22461d2 100644 --- a/tez-ui/src/main/webapp/tests/unit/controllers/home/queries-test.js +++ b/tez-ui/src/main/webapp/tests/unit/controllers/home/queries-test.js @@ -38,6 +38,7 @@ test('Basic creation test', function(assert) { assert.ok(controller.breadcrumbs); assert.ok(controller.headerComponentNames); assert.equal(controller.headerComponentNames.length, 3); + assert.equal(controller.footerComponentNames.length, 1); assert.ok(controller.definition); assert.ok(controller.columns);
