Revert "TEZ-3625. Dag.getVertex should obtain a readlock. (sseth)"
This reverts commit dcae5e42e961a6b2fd0e82a2392d601ca935d0f1. Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/2158b95d Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/2158b95d Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/2158b95d Branch: refs/heads/TEZ-1190 Commit: 2158b95df521b1e49b0a5ee1bd71560bb12234c7 Parents: 359cd75 Author: Siddharth Seth <[email protected]> Authored: Fri Feb 24 12:52:20 2017 -0800 Committer: Siddharth Seth <[email protected]> Committed: Fri Feb 24 12:52:20 2017 -0800 ---------------------------------------------------------------------- CHANGES.txt | 1 - .../src/main/java/org/apache/tez/dag/app/DAGAppMaster.java | 1 - .../main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java | 7 +------ 3 files changed, 1 insertion(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/2158b95d/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index b855af0..34f8624 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -10,7 +10,6 @@ ALL CHANGES: TEZ-3634. reduce the default buffer sizes in PipelinedSorter by a small amount. TEZ-3627. Use queue name available in RegisterApplicationMasterResponse for publishing to ATS. TEZ-3610. TEZ UI 0.7 0.9 compatibility for url query params and tez-app sub-routes - TEZ-3625. Dag.getVertex should obtain a readlock. TEZ-3624. Split multiple calls on the same line in TaskCommunicatorContextImpl. TEZ-3550. Provide access to sessionId/dagId via DagClient. TEZ-3267. Publish queue name to ATS as part of dag summary. http://git-wip-us.apache.org/repos/asf/tez/blob/2158b95d/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java b/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java index 2085789..de02c18 100644 --- a/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java +++ b/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java @@ -2638,7 +2638,6 @@ public class DAGAppMaster extends AbstractService { // Send out an event to inform components that a new DAG has been submitted. // Information about this DAG is available via the context. - // This event may be processed after DAG_INIT, but will be processed before DAG_START sendEvent(new DAGAppMasterEvent(DAGAppMasterEventType.NEW_DAG_SUBMITTED)); // create a job event for job initialization DAGEvent initDagEvent = new DAGEvent(currentDAG.getID(), DAGEventType.DAG_INIT); http://git-wip-us.apache.org/repos/asf/tez/blob/2158b95d/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java index 047fea6..481353b 100644 --- a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java +++ b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java @@ -1810,12 +1810,7 @@ public class DAGImpl implements org.apache.tez.dag.app.dag.DAG, @Override public Vertex getVertex(String vertexName) { - this.readLock.lock(); - try { - return vertexMap.get(vertexName); - } finally { - this.readLock.unlock(); - } + return vertexMap.get(vertexName); } private void mayBeConstructFinalFullCounters() {
