spmallette commented on a change in pull request #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#discussion_r262061101
########## File path: docker/gremlin-server/Dockerfile.template ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM tinkerpop:hadoop-HADOOP_VERSION Review comment: > I guess for that to work we would have to actually publish test images to Docker Hub that already contain the test data. Just to reiterate something I mentioned earlier on the dev list - we should probably keep our docker image publishing restricted to public facing releases given some of the uncertainty on what the asf deems acceptable around this practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
