spmallette commented on a change in pull request #1485:
URL: https://github.com/apache/tinkerpop/pull/1485#discussion_r726105358
##########
File path:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReaderTest.java
##########
@@ -0,0 +1,62 @@
+package org.apache.tinkerpop.gremlin.structure.io.graphml;
+
+import junit.framework.TestCase;
+import org.apache.tinkerpop.gremlin.structure.Graph;
+import org.apache.tinkerpop.gremlin.structure.Vertex;
+import static org.apache.tinkerpop.gremlin.structure.T.label;
+import static org.apache.tinkerpop.gremlin.structure.T.id;
+
+
+import java.io.IOException;
+import java.io.InputStream;
+
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.any;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.atLeastOnce;
+
+public class GraphMLReaderTest extends TestCase {
Review comment:
Good use of mocking here. Two things:
1. I imagine the rat plugin is failing for this build because you don't have
the Apache license header in this new file.
2. Please prefer JUnit annotations over the use of `TestCase` - You may
refer to any of the other unit tests in the code for examples of that style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
