amatiushkin commented on a change in pull request #1485:
URL: https://github.com/apache/tinkerpop/pull/1485#discussion_r727722690
##########
File path: gremlin-core/src/test/resources/graphml/sample.graphml.xml
##########
@@ -0,0 +1,367 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
re: tinkerpop-modern.xml
I also plan to add edge case with CDATA/PDATA once I found any good example.
Does it make sense to make `gremlin-test` component to be a test dependency
for `grenmlin-core`?
I am not a big fun of duplicating things (including test), because it makes
future contributor to be aware to update modern dataset in few more places.
On the other hand, test dependency would add a little bit complexity to the
build process itself.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
