[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628

[GitBox]

spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783202225



##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
                             <goal>execute</goal>
                         </goals>
                         <configuration>
+                            <properties>
+                                <property>
+                                    <name>projectBaseDir</name>
+                                    <value>${project.basedir}</value>
+                                </property>
+                                <property>
+                                    <name>mavenVersion</name>
+                                    <value>${project.version}</value>
+                                </property>
+                            </properties>
                             <scripts>
                                 <script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
 
file.write(file.getText("UTF-8").replaceFirst(/&lt;Version&gt;(.*)&lt;\/Version&gt;/,
 "&lt;Version&gt;" + mavenVersion + "&lt;/Version&gt;"))
 
-file = new 
File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")

Review comment:
       Interesting. Could you mention what was happening here? Why does using a 
`<property>` work but the variable substitution not?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org