phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783333920
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/,
"<Version>" + mavenVersion + "</Version>"))
-file = new
File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
The issue arises from when the string interpolation happens. If the
"${project.basedir}/..." is evaluated by maven then gradle sees the unescaped
string and must parse it.
If the `<property>` approach is used, then the
[gmavenplus-plugin](https://groovy.github.io/GMavenPlus/plugin-info.html)
presents gradle with a string variable (i.e. no string interpolation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
