spmallette commented on pull request #1556: URL: https://github.com/apache/tinkerpop/pull/1556#issuecomment-1040196209
> Without this design document, it would be very hard to code review, since we would have to resort to reverse engineer the contract from the code itself. I think a design document would be helpful - in fact perhaps the Go driver could set a model by which we document all of the drivers. However, I don't think we should place too high a bar on the early stages of this work. We can place a high bar on calling it "production ready" but for purposes of reaching a point where this PR can be merged I think the bar is fairly low. If it can send requests and get back results, that's at least as much as the unofficial drivers do and I think this PR is getting closer to doing far more than that. Personally, I'd advocate for merging early with experimental release candidates for folks to try the functionality and to provide feedback. In the mean time, folks working on this PR can address issues related to getting to a fully production ready driver in additional PRs. As for the driver documentation, i think we should consider expanding (or re-writing) the provider documentation which has server protocol related content in it: https://github.com/apache/tinkerpop/blob/master/docs/src/dev/provider/index.asciidoc#graph-driver-provider-requirements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
