divijvaidya commented on pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#issuecomment-1040599340
@spmallette I agree with most of the things that you mentioned except for
the below.
> We can place a high bar on calling it "production ready" but for purposes
of reaching a point where this PR can be merged I think the bar is fairly low.
If it can send requests and get back results, that's at least as much as the
unofficial drivers do and I think this PR is getting closer to doing far more
than that. Personally, I'd advocate for merging early with experimental release
candidates for folks to try the functionality and to provide feedback.
Once a code is merged to our main TinkerPop repository, we are picking up
the ownership of maintaining it in the future. Thus, the experimental version
aka minimum viable version (MVP) that gets merged into the repository has to
adhere to certain code quality which would help us in code maintenance. The
minimal acceptable standard should be documented code, documented features for
what it can & cannot do, unit & integration tests for the feature which the
client is documented to support and adherence to best practices for build &
code style.
IMO, this PR does not meet that standard right now because of missing
documentation, missing integration tests to handle scenarios such as server and
code styling practices. I am open to discussing a merge in a separate branch
but when merging to master again, the whole body of code would need to go
through a PR.
My preferred approach and suggestion would be to incrementally add features
to a larger project being merged into master while ensuring that each feature
is production ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
