kenhuuu commented on PR #1792: URL: https://github.com/apache/tinkerpop/pull/1792#issuecomment-1233191336
Hi, thanks for contributing. I have a few questions/comments about this PR. 1. It seems like the retry logic may have been missed for submit_async(). 2. Maybe we should consider adding exponential backoff and a maximum number of retries? 3. A possible improvement might be to test if the error should be retried. E.g. don't retry for non-recoverable errors like incorrect password. 4. It may make more sense to handle the connection pool logic in the client. 5. Some added documentation for this feature would probably be useful for others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
