OGoodness commented on PR #1792: URL: https://github.com/apache/tinkerpop/pull/1792#issuecomment-1242576586
@spmallette @FlorianHockmann @kenhuuu ## Question to the team. Based on @spmallette 's comment regarding this feature, the team has avoided trying to implement retries. Is this due to complexity or because the feature is not desirable? If I were to address all these concerns, would it be likely for the PR to be merged in? Want to ensure this is a feature that the team is open to before fleshing out the implementation, if so, I'm more than happy to contribute :D. --- You both bring up great points. Agreed that the current implementation could result in unintended retries, perhaps a custom error that is raised only on retriable requests would be better? @kenhuuu - You mentioned moving some of the logic to the client. I agree, however, my original attempts at this were trying just that. But when you get any deeper than the Driver it can get messy with async code, which I wanted to avoid. - You mention a missed `submit_async`, you're right. If we decide to move forward with this feature I'd be more than happy to add support for it. @FlorianHockmann - Your concern about retrying mutations, this is similar to what I've fixed on some of my personal implementations, but had not implemented into this CR, as @spmallette suggested that this feature was unlikely to pick up. Definitely understand we need to use a lighter touch to our retry logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
