vkagamlyk commented on code in PR #1808:
URL: https://github.com/apache/tinkerpop/pull/1808#discussion_r969992621


##########
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs:
##########
@@ -141,73 +159,73 @@ private GraphTraversal(ICollection<ITraversalStrategy> 
traversalStrategies, Byte
         /// <summary>
         ///     Adds the aggregate step to this <see 
cref="GraphTraversal{SType, EType}" />.
         /// </summary>
-        public GraphTraversal<S, E> Aggregate (Scope scope, string 
sideEffectKey)
+        public GraphTraversal<S, E_> Aggregate (Scope scope, string 
sideEffectKey)
         {
             Bytecode.AddStep("aggregate", scope, sideEffectKey);
-            return Wrap<S, E>(this);
+            return Wrap<S, E_>(this);

Review Comment:
   Class was defined as `public class GraphTraversal<S, E> : 
DefaultTraversal<S, E>`
   [C# don't allow to have method with same name as 
type](https://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0102)
   
   Possible solutions:
   1. rename `E` in class definition (internal effect only, I used it)
   2. rename `E` function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to