FlorianHockmann commented on code in PR #1808:
URL: https://github.com/apache/tinkerpop/pull/1808#discussion_r970537109
##########
gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj:
##########
@@ -67,7 +67,7 @@ NOTE that versions suffixed with "-rc" are considered release
candidates (i.e. p
<RepositoryUrl>https://github.com/apache/tinkerpop</RepositoryUrl>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
- <EnablePackageValidation>true</EnablePackageValidation>
+ <EnablePackageValidation>false</EnablePackageValidation>
Review Comment:
Please revert this change. Package validation ensures that we don't
accidentally add breaking changes without being aware of it.
In this case, we accept the breaking change of renaming the generic type
parameter from `E` to `E_` of `GraphTraversal`. So, we can silence the warning
for this change. You can do this by adding the following entry to the file
`CompatibilitySuppressions.xml` in `gremlin-dotnet/src/Gremlin.Net`:
```xml
<!-- Renamed generic type parameter name in GraphTraversal -->
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Gremlin.Net.Process.Traversal.GraphTraversal`2</Target>
<Left>lib/netstandard2.0/Gremlin.Net.dll</Left>
<Right>lib/netstandard2.0/Gremlin.Net.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
```
behind the other two suppression entries there.
I realize though that this compatibility checking and how to deal with its
warnings isn't easy to understand, especially for non-.NET developers who just
want to modify Gremlin and therefore also have to make changes in .NET. So, I'm
wondering whether we should keep the feature at all. Nevertheless, that
shouldn't be part of this PR, so please add the suppression for now and
reenable the validation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
