spmallette commented on code in PR #1808:
URL: https://github.com/apache/tinkerpop/pull/1808#discussion_r972391096
##########
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs:
##########
@@ -141,73 +159,73 @@ private GraphTraversal(ICollection<ITraversalStrategy>
traversalStrategies, Byte
/// <summary>
/// Adds the aggregate step to this <see
cref="GraphTraversal{SType, EType}" />.
/// </summary>
- public GraphTraversal<S, E> Aggregate (Scope scope, string
sideEffectKey)
+ public GraphTraversal<S, E_> Aggregate (Scope scope, string
sideEffectKey)
{
Bytecode.AddStep("aggregate", scope, sideEffectKey);
- return Wrap<S, E>(this);
+ return Wrap<S, E_>(this);
Review Comment:
when you merge from 3.5-dev to 3.6-dev and 3.6-dev to master, yes, you will
need to add some follow-on work there to cover the new steps that we've added
like `mergeV/E()`. i guess this isn't a breaking change though so you should be
able to just issue a follow-on PR without having to worry about breaking the
build in either of the downstream branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
