FlorianHockmann commented on code in PR #1808:
URL: https://github.com/apache/tinkerpop/pull/1808#discussion_r972673601
##########
gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj:
##########
@@ -67,7 +67,7 @@ NOTE that versions suffixed with "-rc" are considered release
candidates (i.e. p
<RepositoryUrl>https://github.com/apache/tinkerpop</RepositoryUrl>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
- <EnablePackageValidation>true</EnablePackageValidation>
+ <EnablePackageValidation>false</EnablePackageValidation>
Review Comment:
You can generate the file automatically:
```bash
dotnet pack gremlin-dotnet/src/Gremlin.Net
/p:GenerateCompatibilitySuppressionFile=true
```
or apparently also if you temporarily add this to the Gremlin.Net.csproj:
```xml
<GenerateCompatibilitySuppressionFile>true</GenerateCompatibilitySuppressionFile>
```
as described
[here](https://docs.microsoft.com/en-us/dotnet/fundamentals/package-validation/overview#suppress-compatibility-errors).
This will remove the comments that we currently have in the file, but I
guess those aren't that helpful any way so it shouldn't be a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
