cole-bq commented on code in PR #1838: URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1017281136
########## gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsUserAgentHandler.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.server.handler; + +import io.netty.channel.ChannelHandlerContext; +import io.netty.channel.ChannelInboundHandlerAdapter; +import io.netty.handler.codec.http.HttpHeaders; +import io.netty.handler.codec.http.websocketx.WebSocketServerProtocolHandler; +import io.netty.util.AttributeKey; +import org.apache.tinkerpop.gremlin.driver.util.UserAgent; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Channel handler which extracts a user agent header from a web socket handshake if present + * then logs the user agent and stores it as a channel attribute for future reference. + */ +public class WsUserAgentHandler extends ChannelInboundHandlerAdapter { Review Comment: I agree, best to keep logs clearer and aggregated user agents will be more useful too. I have incorporated these suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
