spmallette commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1017823259
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -993,6 +1002,16 @@ public Builder connectionSetupTimeoutMillis(final long
connectionSetupTimeoutMil
return this;
}
+ /**
+ * Configures whether cluster will send a user agent during
+ * web socket handshakes
+ * @param enableUserAgentOnConnect true enables the useragent. false
disables the useragent.
+ */
+ public Builder enableUserAgentOnConnect(boolean
enableUserAgentOnConnect) {
+ this.wsHandshakeUserAgentEnabled = enableUserAgentOnConnect;
Review Comment:
it seems like you went with the rename i suggested - please rename the
underlying variables as well to keep things consistent.
nit: `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
