cole-bq commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1029966286
##########
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/WebSocketClientBehaviorIntegrateTest.java:
##########
@@ -88,6 +89,44 @@ public void shutdown() {
rootLogger.removeAppender(recordingAppender);
}
+ /**
+ * Tests that client is correctly sending user agent during web socket
handshake by having the server return
+ * the captured user agent.
+ */
+ @Test
+ public void shouldIncludeUserAgentInHandshakeRequest() {
Review Comment:
On further inspection I'm less sure that any test of this nature would be
useful. Since the user agent is sent as an http header during the handshake, it
is by definition only sent once per connection. Once the handshake is done and
the connection established, there isn't really anywhere to check for a user
agent being sent again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
