cole-bq commented on code in PR #1838: URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1029806753
########## docs/src/dev/provider/index.asciidoc: ########## @@ -848,6 +848,14 @@ Server returns for a single request. Again, this description of Gremlin Server' out-of-the-box configuration. It is quite possible to construct other flows, that might be more amenable to a particular language or style of processing. +It is recommended but not required that a driver include a `User-Agent` header as part of any web socket Review Comment: How much value do you see in having such a benchmark? My understanding is that the jmh benchmarks aren't currently setup for measuring anything like the driver handshake latency. I also have concerns about how usefulness of any result as the latency will be highly dependent on network conditions. A typical user agent in the format we are using is under 100 bytes and it is only sent once per connection in the handshake. Personally I don't foresee there being any noticeable side effects other than the obvious added logging and metrics. Some sort of benchmark can certainty be added but I don't believe it will be trivial to add and I worry it won't offer much value for the investment put into creating it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
