vkagamlyk commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394545976
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsAndHttpChannelizerHandler.java:
##########
@@ -62,28 +63,35 @@ public void configure(final ChannelPipeline pipeline) {
public void channelRead(final ChannelHandlerContext ctx, final Object obj)
{
final ChannelPipeline pipeline = ctx.pipeline();
if (obj instanceof HttpMessage &&
!WebSocketHandlerUtil.isWebSocket((HttpMessage)obj)) {
- // if the message is for HTTP and not websockets then this handler
injects the endpoint handler in front
- // of the HTTP Aggregator to intercept the HttpMessage. Therefore
the pipeline looks like this at start:
+ // If the message is for HTTP and not WS then this handler injects
the HTTP user-agent and endpoint handlers
+ // in front of the HTTP aggregator to intercept the HttpMessage.
+ // This replaces the WS server protocol handler so that the
pipeline initially looks like this:
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
// WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
+ // WebSocketServerProtocolHandler ->
// WebSocketServerCompressionHandler ->
WebSocketServerProtocolHandshakeHandler -> (more websockets)
//
- // and shifts to (setting aside the authentication condition):
+ // and shifts to this (setting aside the authentication condition):
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
// WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
- // HttpGremlinEndpointHandler ->
+ // HttpUserAgentHandler -> HttpGremlinEndpointHandler ->
// WebSocketServerCompressionHandler -
WebSocketServerProtocolHandshakeHandler -> (more websockets)
+ ChannelHandler test = pipeline.get(PIPELINE_REQUEST_HANDLER);
Review Comment:
nit: remove debug code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
