ryn5 commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1396467185
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsAndHttpChannelizerHandler.java:
##########
@@ -69,7 +69,6 @@ public void channelRead(final ChannelHandlerContext ctx,
final Object obj) {
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
// WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
- // WebSocketServerProtocolHandler ->
// WebSocketServerCompressionHandler ->
WebSocketServerProtocolHandshakeHandler -> (more websockets)
Review Comment:
I think it'd be better to keep this step since it makes clear what line 80
is removing and provides context on what is being replaced by the
HttpGremlinEndpointHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
