Cole-Greer commented on code in PR #2919: URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1861046651
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/GType.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal.step; + +import org.apache.tinkerpop.gremlin.process.traversal.Path; +import org.apache.tinkerpop.gremlin.structure.Edge; +import org.apache.tinkerpop.gremlin.structure.Property; +import org.apache.tinkerpop.gremlin.structure.Vertex; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** + * An enum that describes types that are used in the Gremlin language. + */ +public enum GType { + BIG_DECIMAL(BigDecimal.class), + BIG_INTEGER(BigInteger.class), + BOOLEAN(Boolean.class), + DOUBLE(Double.class), + EDGE(Edge.class), + INTEGER(Integer.class), + LIST(List.class), + LONG(Long.class), + MAP(Map.class), + PATH(Path.class), + PROPERTY(Property.class), + SET(Set.class), + STRING(String.class), + UNKNOWN(null), + VERTEX(Vertex.class); + + private Class<?> javaType; + + GType(final Class<?> javaType) { + this.javaType = javaType; + } + + public Class<?> getJavaType() { + return this.javaType; + } + + /** + * Returns {@code true} if the type is a number. + */ + public boolean isNumeric() { + return this == INTEGER || this == DOUBLE || this == LONG || this == BIG_INTEGER || this == BIG_DECIMAL; + } + + /** + * Returns {@code true} if the type is a collection.v + */ + public boolean isCollection() { + return this == LIST || this == SET; + } + + /** + * Returns {@code true} if the type is an element. + */ + public boolean isElement() { + return this == VERTEX || this == EDGE; + } + + /** + * Convert an object to a matching {@link GType} and if not matched return {@link GType#UNKNOWN}. + */ + public static GType getType(final Object object) { + if (object instanceof String) return STRING; Review Comment: Such a map here would be simpler, except it may present a limitation in the cases of the interface types (Map, List, Vertex...). In these cases, a simple class to GType map won't easily capture all of the possible implementing classes (LinkedHashMap, HashMap, LinkedList, ArrayList, DetachedVertex, TinkerVertex...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
