Cole-Greer commented on code in PR #2919:
URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1862714040
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/CoinStep.java:
##########
@@ -73,7 +85,7 @@ public String toString() {
@Override
public int hashCode() {
- return super.hashCode() ^ Double.hashCode(this.probability);
+ return super.hashCode() ^ Double.hashCode(this.probability.get());
Review Comment:
Those will not be equivalent as GValue.hashCode() combines the hash of the
name, type, and value. I believe it's best if the equality of CoinStep is based
on the value of the probability, not the name of any parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
