Cole-Greer commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2033798312
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -22,6 +22,12 @@ grammar Gremlin;
PARSER RULES
**********************************************/
+gremlinValue
+ : (numericLiteral | booleanLiteral | stringLiteral | dateLiteral |
nullLiteral | nanLiteral | infLiteral |
+ traversalT | traversalCardinality | traversalDirection | traversalMerge
|
+ structureVertex | genericLiteralSet | genericLiteralCollection |
genericLiteralMap) EOF
Review Comment:
I'm wondering if we need some sort of `gremlinValueSet`,
`gremlinValueCollection`, and `gremlinValueMap`. It's a bit weird that
`DT.hour` is not a valid gremlinValue, but `[DT.hour]` is a gremlinValue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
