Cole-Greer commented on code in PR #3091: URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2033983487
########## gremlin-language/src/test/resources/gremlin-values.txt: ########## @@ -0,0 +1,419 @@ +# numericLiteral +0 +1 +123 +9999 ++1 +-1 ++123 +-123 +1_000 +1_000_000 +123L +123l +123B +123b +123S +123s +123N +123n +123I +123i +-123L ++456S +-789b +0x0 +0x1 +0xA +0xFF +0x123ABC ++0x123 +-0x456 +0x1_FF +0xABCl +0xDEFi +0x123 +0X123 +00 +01 +07 +0123 ++0123 +-0456 +0123_456 +0123l +0456s +0.0 +1.0 +123.456 ++1.0 +-1.0 ++123.456 +-123.456 +1e2 +1.0e2 +1e+2 +1e-2 +1.23e45 ++1.23e45 +-1.23e45 ++1.23e+45 +-1.23e-45 +1.0f Review Comment: This isn't directly related to the changes here but I just noticed that something like `.5f` is not parseable as a floatLiteral in the grammar. That's another subtle difference from groovy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
