Cole-Greer commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2392513383
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AsNumberStep.java:
##########
@@ -34,16 +34,24 @@
*/
public class AsNumberStep<S> extends ScalarMapStep<S, Number> {
- private N numberToken;
+ private GType typeToken;
public AsNumberStep(final Traversal.Admin traversal) {
super(traversal);
- this.numberToken = null;
+ this.typeToken = null;
}
- public AsNumberStep(final Traversal.Admin traversal, final N numberToken) {
+ public AsNumberStep(final Traversal.Admin traversal, final GType
numberToken) {
super(traversal);
- this.numberToken = numberToken;
+ if (!numberToken.isNumeric())
+ throw new IllegalArgumentException("asNumber() requires a numeric
type token, got " + numberToken);
+ this.typeToken = numberToken;
+ }
+
+ // TODO potential extension to use class
+ public AsNumberStep(final Traversal.Admin traversal, final Class<?>
numberToken) {
Review Comment:
Is the intention to keep this?
Nit: If it stays, the signature can be restricted slightly to
```suggestion
public AsNumberStep(final Traversal.Admin traversal, final Class<?
extends Number> numberToken) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
