xiazcy commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2421191578
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/translator/GremlinTranslatorTest.java:
##########
@@ -741,24 +741,51 @@ public static Collection<Object[]> data() {
null,
null,
"g.inject(long(1694017707000)).as_date()"},
- {"g.inject(\"123.4\").asNumber(N.int)",
- null,
- "g.inject(string0).asNumber(N.int)",
- "g.Inject<object>(\"123.4\").AsNumber(N.Int)",
- "g.Inject(\"123.4\").AsNumber(gremlingo.N.Int)",
- "g.inject(\"123.4\").asNumber(N.int_)",
- "g.inject(\"123.4\").asNumber(N.int_)",
- "g.inject(\"123.4\").asNumber(N.int_)",
- "g.inject('123.4').as_number(N.int)"},
- {"g.inject(\"123.4\").asNumber(N.bigInt)",
- null,
- "g.inject(string0).asNumber(N.bigInt)",
- "g.Inject<object>(\"123.4\").AsNumber(N.BigInt)",
- "g.Inject(\"123.4\").AsNumber(gremlingo.N.BigInt)",
- "g.inject(\"123.4\").asNumber(N.bigInt)",
- "g.inject(\"123.4\").asNumber(N.bigInt)",
- "g.inject(\"123.4\").asNumber(N.bigInt)",
- "g.inject('123.4').as_number(N.big_int)"},
+ {"g.inject(\"123.4\").asNumber(GType.INT)",
+ null,
+ "g.inject(string0).asNumber(GType.INT)",
+ "g.Inject<object>(\"123.4\").AsNumber(GType.Int)",
+
"g.Inject(\"123.4\").AsNumber(gremlingo.GType.Int)",
+ "g.inject(\"123.4\").asNumber(GType.INT)",
+ "g.inject(\"123.4\").asNumber(GType.INT)",
+ "g.inject(\"123.4\").asNumber(GType.int)",
+ "g.inject('123.4').as_number(GType.INT)"},
+ {"g.inject(\"123.4\").asNumber(GType.BIGINT)",
Review Comment:
`null` actually means the translations are no difference from the original
input, the tests are still ran against them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
