spmallette commented on code in PR #3211: URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2441091480
########## gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/data/Byte.feature: ########## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +@StepClassData @DataByte Review Comment: The further down i go reviewing these `StepClassData` tests, the more I think something doesn't look quite right with not storing an actual `byte` in some of these tests. For example, the `Map`, `List` and `Set` tests all go so far as to store instances of those in a graph, so much so that I wondered if we had enough coverage for when graphs opted out of those, as many/most can't do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
