Cole-Greer commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2392577130
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/PTest.java:
##########
@@ -233,6 +233,12 @@ public static Iterable<Object[]> data() {
{P.within().or(P.within()), 0, false},
{P.within().or(P.without()), 0, true},
{P.without().or(P.without()), 0, true},
+
+ {P.typeOf(GType.NUMBER), 1, true},
+ {P.typeOf(GType.STRING), "hello", true},
+ {P.typeOf(Boolean.class), false, true},
+ {P.typeOf(GType.NULL), null, true},
Review Comment:
Can you include a few false cases here as well?
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/PTest.java:
##########
@@ -233,6 +233,12 @@ public static Iterable<Object[]> data() {
{P.within().or(P.within()), 0, false},
{P.within().or(P.without()), 0, true},
{P.without().or(P.without()), 0, true},
+
+ {P.typeOf(GType.NUMBER), 1, true},
+ {P.typeOf(GType.STRING), "hello", true},
+ {P.typeOf(Boolean.class), false, true},
+ {P.typeOf(GType.NULL), null, true},
Review Comment:
Could you include a few false cases here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
