spmallette commented on code in PR #3233: URL: https://github.com/apache/tinkerpop/pull/3233#discussion_r2441161012
########## docs/src/recipes/collections.asciidoc: ########## @@ -190,9 +190,9 @@ of "java"). Note however that the `by()` modulator overrides that traverser comp the list of vertices in "v". Those vertices are unfolded to retrieve the name property from each and then are reduced with `fold()` back into a list to be stored in the side-effected named "b". <5> A similar use of `aggregate()` as the previous step, though this one turns "e" into a stream of edges to calculate -the `mean()` to store in a `List` called "c". Note that `aggregate()` (short form for `aggregate(global)`) was used -here instead of `aggregate(local)`, as the former is an eager collection of the elements in the stream -(`aggregate(local)` is lazy) and will force the traversal to be iterated up to that point before moving forward. +the `mean()` to store in a `List` called "c". Note that `aggregate()` with `local()` was used Review Comment: i think some of this content is in the wrong place. we deprecated in 3.7.x, so we want folks to start using the new form there. if we only deprecate and don't present the new pattern along with it, how will they understand the new form as they face deprecation? i think the 3.7.x docs should reflect the changes in the reference docs, recipes, etc. in that version, UNLESS, we've changed something in the semantics that only allow these changes in 3.8.0 (in which case there really isn't a deprecation path and maybe the #3234 doesn't make sense? thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
