xiazcy commented on code in PR #3233:
URL: https://github.com/apache/tinkerpop/pull/3233#discussion_r2420991963


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/EarlyLimitStrategyTest.java:
##########
@@ -91,10 +92,7 @@ public static Iterable<Object[]> generateTestParameters() {
                     {__.out().map(__.identity()).map(__.identity()).range(50, 
100).map(__.identity()).map(__.identity()).range(50, -1), __.out().discard(), 
Collections.emptyList()},
                     {__.out().map(__.identity()).map(__.identity()).range(50, 
100).map(__.identity()).map(__.identity()).range(60, -1), __.out().discard(), 
Collections.emptyList()},
                     {__.out().map(__.identity()).map(__.identity()).range(50, 
100).as("a").map(__.identity()).map(__.identity()).range(60, -1).as("b"), 
__.out().discard(), Collections.emptyList()},
-                    {__.out().range(50, 100).store("a").range(50, -1), 
__.out().range(50, 100).store("a").discard(), Collections.emptyList()},

Review Comment:
   No, EarlyLimitStrategy doesn't apply to aggregate global (even if it's 
wrapped inside of a local). This is the one of the thing that's a strategy 
limitation and not a semantics difference. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to