kenhuuu commented on code in PR #3231:
URL: https://github.com/apache/tinkerpop/pull/3231#discussion_r2408143293
##########
gremlin-python/src/main/python/examples/modern_traversals.py:
##########
@@ -31,7 +32,16 @@ def main():
# This example requires the Modern toy graph to be preloaded upon
launching the Gremlin server.
# For details, see
https://tinkerpop.apache.org/docs/current/reference/#gremlin-server-docker-image
and use
# conf/gremlin-server-modern.yaml.
- rc = DriverRemoteConnection('ws://localhost:8182/gremlin', 'g')
+ # if there is a port placeholder in the env var then we are running with
docker so set appropriate port
+ server_url = os.getenv('GREMLIN_SERVER_URL',
'ws://localhost:8182/gremlin').format(45940)
+
+ # CI uses port 45940 with gmodern binding, local uses 8182 with g binding
Review Comment:
If these examples are meant to be user facing, then I'd argue comments like
these about usage with the internal CI system are confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
