kirill-stepanishin commented on code in PR #3231:
URL: https://github.com/apache/tinkerpop/pull/3231#discussion_r2411756822
##########
gremlin-python/docker-compose.yml:
##########
@@ -75,7 +75,12 @@ services:
&& python3 ./setup.py test
&& python3 ./setup.py install
&& radish -f dots -e -t -b ./radish ./gremlin-test
--user-data='serializer=application/vnd.gremlin-v3.0+json'
- && radish -f dots -e -t -b ./radish ./gremlin-test
--user-data='serializer=application/vnd.graphbinary-v1.0';
+ && radish -f dots -e -t -b ./radish ./gremlin-test
--user-data='serializer=application/vnd.graphbinary-v1.0'
+ && echo 'Running examples...'
Review Comment:
Good suggestion! I tried and the main challenge is that the Gremlin server
stops when integration tests complete, so a separate examples service can't
connect to the same server instance. This would require either launching
separate server instances for examples or reworking the docker compose
orchestration to keep the server alive between test phases. I don't know if
it's worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
