Cole-Greer commented on code in PR #3119:
URL: https://github.com/apache/tinkerpop/pull/3119#discussion_r2495313071
##########
.github/workflows/build-test.yml:
##########
@@ -198,16 +198,67 @@ jobs:
run: |
mvn clean install -pl $EXCLUDE_MODULES -q -DskipTests -Dci
mvn verify -pl gremlin-driver -DskipIntegrationTests=false
- javascript:
- name: javascript
+ javascript-node20:
+ name: javascript-all-node20
timeout-minutes: 15
needs: cache-gremlin-server-docker-image
- runs-on: ${{ matrix.os }}
- strategy:
- matrix:
- # Windows Disabled until Linux containers are supported on Windows
runners: https://github.com/actions/virtual-environments/issues/252
- # os: [ubuntu-latest, windows-latest]
- os: [ubuntu-latest]
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v5
+ - name: Set up JDK 11
+ uses: actions/setup-java@v5
+ with:
+ java-version: '11'
+ distribution: 'temurin'
+ - name: Get Cached Server Base Image
+ uses: actions/cache@v4
+ id: gremlin-server-test-docker-image
+ with:
+ path: |
+ ./gremlin-server/*
+ ~/.m2/repository/org/apache/tinkerpop/*
+ key: ${{ github.sha }}
+ - name: Load Docker Image
+ working-directory: ./gremlin-server
+ run: docker load --input gremlin-server.tar
+ - name: Build with Maven
+ run: |
+
EXCLUDE="-:gremlin-dotnet-source,-:gremlin-dotnet-tests,-:gremlin-go,-:gremlin-python,$EXCLUDE_FOR_GLV"
+ mvn clean install -pl $EXCLUDE -q -DskipTests -Dci
+ mvn verify -pl :gremlin-javascript,:gremlint,:gremlin-mcp
-Dnode.test.version=20
Review Comment:
Historically we've always tested gremlint (and now gremlin-mcp) as well
through the `javascript` job in github actions. I've retained that here with
testing on the current minimum version (node 20), which is what the "all" in
the name `javascript-all-node20` is referring to.
Ideally I'd like to be testing gremlint and gremlin-mcp on the newer node
versions as well, but those builds are not currently dockerized so they are in
need of a different solution (which is why the node 22 and 24 jobs are
currently glv-only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
