Cole-Greer commented on code in PR #3119:
URL: https://github.com/apache/tinkerpop/pull/3119#discussion_r2505369951
##########
pom.xml:
##########
@@ -226,6 +226,7 @@ limitations under the License.
<runtime.npm.version>10.8.2</runtime.npm.version>
<runtime.node.version>v20.19.4</runtime.node.version>
+ <node.test.version>20</node.test.version>
Review Comment:
`runtime.node.version` needs to be in its exact format
(`vMAJOR.MINOR.PATCH`) to work with `frontend-maven-plugin`. I wanted to
continue using the docker major version tag, without pinning minor and patch
versions, also at minimum the `v` would need to be parsed out of the
`runtime.node.version`. This version extraction would need to happen either in
the pom file when the version is injected as an environment variable, or within
`docker.compose.yml` when the node image is fetched. I didn't find a nice way
to get this working so I went with the simpler (albeit redundant) approach.
I admittedly didn't spend much time on this, there likely is a better way to
extract the version which I haven't found yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
