kirill-stepanishin commented on code in PR #3307:
URL: https://github.com/apache/tinkerpop/pull/3307#discussion_r2823344516
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/traversal-test.js:
##########
@@ -28,69 +28,12 @@ import anon from '../../lib/process/anonymous-traversal.js';
import { P, order, direction, Traverser, Traversal } from
'../../lib/process/traversal.js';
import { statics } from '../../lib/process/graph-traversal.js';
const V = statics.V;
-import Bytecode from '../../lib/process/bytecode.js';
+
import { TraversalStrategies } from '../../lib/process/traversal-strategy.js';
import { RemoteConnection } from '../../lib/driver/remote-connection.js';
describe('Traversal', function () {
- describe('#getByteCode()', function () {
- it('should add steps for with a string parameter', function () {
- const g = anon.traversal().with_(new Graph());
- const bytecode = g.V().out('created').getBytecode();
- assert.ok(bytecode);
- assert.strictEqual(bytecode.sourceInstructions.length, 0);
- assert.strictEqual(bytecode.stepInstructions.length, 2);
- assert.strictEqual(bytecode.stepInstructions[0][0], 'V');
- assert.strictEqual(bytecode.stepInstructions[1][0], 'out');
- assert.strictEqual(bytecode.stepInstructions[1][1], 'created');
- });
-
- it('should add steps with an enum value', function () {
- const g = anon.traversal().with_(new Graph());
- const bytecode = g.V().order().by('age', order.desc).getBytecode();
- assert.ok(bytecode);
- assert.strictEqual(bytecode.sourceInstructions.length, 0);
- assert.strictEqual(bytecode.stepInstructions.length, 3);
- assert.strictEqual(bytecode.stepInstructions[0][0], 'V');
- assert.strictEqual(bytecode.stepInstructions[1][0], 'order');
- assert.strictEqual(bytecode.stepInstructions[2][0], 'by');
- assert.strictEqual(bytecode.stepInstructions[2][1], 'age');
- assert.strictEqual(typeof bytecode.stepInstructions[2][2], 'object');
- assert.strictEqual(bytecode.stepInstructions[2][2].typeName, 'Order');
- assert.strictEqual(bytecode.stepInstructions[2][2].elementName, 'desc');
- });
-
- it('should add steps with Direction aliases from_ and to properly mapped
to OUT and IN', function () {
Review Comment:
Added test cases to `gremlin-lang-test.ts` in
https://github.com/apache/tinkerpop/commit/ee834e1e7c3467d1faf4640c1676b4f42c3cc98c
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/traversal-test.js:
##########
@@ -306,67 +249,7 @@ describe('Traversal', function () {
});
});
- describe('#shouldExtractIdFromVertex()', function () {
- const g = anon.traversal().with_(new Graph());
- it('should extract ID from Vertex objects for V()', function () {
- // Test basic V() step with mixed ID types
- const vStart = g.V(1, new Vertex(2, 'person'));
- const vStartBytecode = vStart.getBytecode();
- assert.strictEqual(vStartBytecode.stepInstructions[0][0], 'V');
- assert.strictEqual(vStartBytecode.stepInstructions[0][1], 1);
- assert.strictEqual(vStartBytecode.stepInstructions[0][2], 2); // ID
should be extracted from Vertex
-
- // Test V() step in the middle of a traversal
- const vMid = g.inject('foo').V(1, new Vertex(2, 'person'));
Review Comment:
Added test cases to `gremlin-lang-test.ts` in
https://github.com/apache/tinkerpop/commit/ee834e1e7c3467d1faf4640c1676b4f42c3cc98c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
