kirill-stepanishin commented on code in PR #3307:
URL: https://github.com/apache/tinkerpop/pull/3307#discussion_r2823345914
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/traversal-test.js:
##########
@@ -306,67 +249,7 @@ describe('Traversal', function () {
});
});
- describe('#shouldExtractIdFromVertex()', function () {
- const g = anon.traversal().with_(new Graph());
- it('should extract ID from Vertex objects for V()', function () {
- // Test basic V() step with mixed ID types
- const vStart = g.V(1, new Vertex(2, 'person'));
- const vStartBytecode = vStart.getBytecode();
- assert.strictEqual(vStartBytecode.stepInstructions[0][0], 'V');
- assert.strictEqual(vStartBytecode.stepInstructions[0][1], 1);
- assert.strictEqual(vStartBytecode.stepInstructions[0][2], 2); // ID
should be extracted from Vertex
-
- // Test V() step in the middle of a traversal
- const vMid = g.inject('foo').V(1, new Vertex(2, 'person'));
- const vMidBytecode = vMid.getBytecode();
- assert.strictEqual(vMidBytecode.stepInstructions[0][0], 'inject');
- assert.strictEqual(vMidBytecode.stepInstructions[0][1], 'foo');
- assert.strictEqual(vMidBytecode.stepInstructions[1][0], 'V');
- assert.strictEqual(vMidBytecode.stepInstructions[1][1], 1);
- assert.strictEqual(vMidBytecode.stepInstructions[1][2], 2); // ID should
be extracted from Vertex
- });
- it('should extract ID from Vertex objects for from()/to()', function () {
- // Test edge creation with from/to vertices
- const fromTo = g.addE('Edge').from_(new Vertex(1, 'person')).to(new
Vertex(2, 'person'));
- const fromToBytecode = fromTo.getBytecode();
- assert.strictEqual(fromToBytecode.stepInstructions[0][0], 'addE');
- assert.strictEqual(fromToBytecode.stepInstructions[0][1], 'Edge');
- assert.strictEqual(fromToBytecode.stepInstructions[1][0], 'from');
- assert.strictEqual(fromToBytecode.stepInstructions[1][1], 1); // ID
should be extracted from Vertex
- assert.strictEqual(fromToBytecode.stepInstructions[2][0], 'to');
- assert.strictEqual(fromToBytecode.stepInstructions[2][1], 2); // ID
should be extracted from Vertex
- });
- it('should extract ID from Vertex objects for mergeE()', function () {
Review Comment:
Added test cases to `gremlin-lang-test.ts` in
https://github.com/apache/tinkerpop/commit/ee834e1e7c3467d1faf4640c1676b4f42c3cc98c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
