kartikey321 commented on PR #3451:
URL: https://github.com/apache/tinkerpop/pull/3451#issuecomment-4665272247
Hi @Cole-Greer, thanks for taking a look and for the detailed notes.
On how I approached it: the initial architecture was based on the
TinkerPop 4.x HTTP transport and GraphBinary v4 format. I used the existing
GLVs and TinkerPop docs as references, but the Dart driver was not copied from
one specific driver. The main motivation came from my own JanusGraph/TinkerPop
usage and the friction of using js driver
I also wanted to be clear about AI usage. The initial direction and
architecture were mine. I used Claude Code to help expand the implementation
once the shape of the driver was in place, and I used Codex for incremental
and adverserial review, bug hunting, and test-focused checks. I reviewed the
code and behaviour myself throughout
Your build/test points make sense. I agree the Docker setup should follow
the existing non-Java GLV pattern instead of having a custom server setup. I’ll
look at the Python setup and the shared `docker/gremlin-test-server/Dockerfile`
approach.
For feature tests, I agree that extracting Gremlin strings is only a
starting point. It helped validate the HTTP + GraphBinary path, but the better
long-term setup is generated native Dart traversal tests through the
translator/generate.groovy flow. I may need some help there once the dev-list
direction is clearer.
For the two failing tests, I’ll keep checking them carefully:
- for `g.inject([null,null]).conjoin("+")`, I’ll verify whether Dart is
mishandling the empty string/null result path or whether the server response
differs from what the feature expects.
- for the sack/float case, I’ll verify that the client is preserving the
`0.5f` literal and then adjust the test tolerance only
if it is just normal floating point precision behavior.
I’ll avoid large churn on the PR while the dev-list discussion is still
open, but I’m happy to keep aligning the driver with the existing GLV
conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
