spmallette commented on PR #3451: URL: https://github.com/apache/tinkerpop/pull/3451#issuecomment-4769951306
> The feature tests no longer submit raw Gremlin strings to the server. I implemented a Dart ANTLR visitor (GremlinAntlrToDart) that mirrors Java's GremlinAntlrToJava approach That's an interesting pattern. I'm curious what other committers think about that. That runs opposite to all language variants exception Java in that python, go, .net and javascript all use Java `Translator` infrastructure to dynamically generate a static compileble source file at build time. That helps test the translators themselves which is helpful. For the case of Tinkubator, though I'm not sure what that means since there wouldn't be a `DartTranslator` in `gremlin-core` to test. I suppose it could be written in groovy and then used as part of that script that generates the test source file, but there's clearly a decision to be made there. That said, I think there is value in each language variant knowing more about the ANTLR grammar, so the approach is interesting. We already have that in javascript and I could see that value elsewhere. I guess I wonder if this a better and improved way to test? > Given the dev list and Stephen's commit, it sounds like tinkubator/gremlin-dart/ is the right home rather than a root-level gremlin-dart/ module. Should I restructure and retarget this PR for that directory? From my perspective, that's the right place. I don't know what that means though from a maven reactor perspective. I suspect we would want gremlin-dart to be a standalone maven project. I guess that means some replication in the pom.xml to do that. Thanks for sticking with this PR while we sort out exactly how to do this. In some ways your work here is breaking some new ground on how we do things so we appreciate the patience as things get figured out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
