spmallette commented on code in PR #3458:
URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3439543513
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/InlineFilterStrategy.java:
##########
@@ -114,6 +114,10 @@ step instanceof OrStep && processOrStep((OrStep) step,
traversal) ||
///////////////////////////
private static boolean processHasStep(final HasStep<?> step, final
Traversal.Admin<?, ?> traversal) {
+ if
(step.getHasContainers().stream().anyMatch(HasContainer::hasTraversal)) return
false;
Review Comment:
we changed this strategy, but i don't see any unit tests here:
https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/InlineFilterStrategyTest.java
i think it would be good to add some cases demonstrating these shortcircuit
points. i think i'd like more inline code comments around the short circuiting.
Update to the class javadoc also seems like a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
