spmallette commented on code in PR #3458: URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3439730553
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/AcceptsChildPredicateTraversal.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal.step; + +/** + * Marker interface for steps that accept user-supplied child traversals embedded as predicate or lookup + * arguments (for example {@code has(key, traversal)}, {@code is(P.gt(traversal))}, + * {@code V(traversal)}, or {@code property(traversal)}). + * <p> + * The {@link org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ChildTraversalVerificationStrategy} + * validates the local children of every step implementing this interface, rejecting child traversals that + * contain mutating steps. New steps that accept such traversals should implement this interface so they are + * validated automatically rather than relying on a hardcoded step list. + * + * @since 4.0.0 + */ +public interface AcceptsChildPredicateTraversal { Review Comment: I don't really like this name: `AcceptsChildPredicateTraversal `. It's plainly descriptive but I'd like something more functional. How about: `DynamicSelecting"? Meaning the step is one that allows for dynamic selection of a value as an argument. This differs from a step that happens to already take `Traversal` in that the implication of "Selecting" is that it is not allowing just any `Traversal` - its is for selection only (i.e. no mutations). It's late...maybe a better name is out there along those lines, but `AcceptsChildPredicateTraversal` is not it imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
