spmallette commented on code in PR #3458: URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3443906572
########## gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/ReadOnlyChildVerification.feature: ########## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: At a minimum, this test set does not really belong in this directory, but i feel like these tests should just be dispersed among their individual step files. That said, I wonder if we are over-testing this at the Gherkin level? There are some general problems with the tests themselves, in misuse of `@GraphComputerVerificationMidVNotSupported`. Maybe could go to the `integrated/` directory - probably then ok to just keep it as-is and whole. Ensure it has the common tests we have for all strategies in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
