spmallette commented on code in PR #3458: URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3443937188
########## gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/HasTraversal.feature: ########## @@ -0,0 +1,433 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: All of these `*Traversal.feature` tests should be integrated to their parent step files. For this file, the fact that every single test has `@GraphComputerVerificationMidVNotSupported` tells me something is wrong because it either means we've mis-labeled the test (as happened elsewhere) or we don't have all the right testing. Where are the tests for use cases with `select()` for example? I know `V()` is popular but `select()` will equally come into play. That approach and others seem necessary. What about filtering on a `sack()` value? that might be interesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
