kenhuuu opened a new pull request, #3508:
URL: https://github.com/apache/tinkerpop/pull/3508
Collapses the per-request execution timeout onto a single name, `timeoutMs`,
across the server config, the script `with()` token, the internal executor,
error messages, and all five GLV APIs. The legacy `evaluationTimeout` and
`scriptEvaluationTimeout` names are removed with no alias.
The point of the change was to eliminate a dual-name inconsistency, so it
made little sense to stop halfway. The 4.x wire protocol already used
`timeoutMs` while the config key, script token, and three drivers still spoke
`evaluationTimeout` — the server even resolved the effective timeout by
checking both names. Renaming only some surfaces would relocate that confusion
rather than remove it, and leaving the driver builder methods on the old name
would trade a wire-vs-config mismatch for a wire-vs-API one.
Review guide:
This is another PR that is mostly a search and replace of
`evaluationTimeout` to `timeoutMs`. What's important for other reviewers to
decide is whether this change should have applied as widely as it did. This
effectively changes it everywhere including in the server where the YAML will
just read `timeoutMs`. `evaluationTimeout` is arguably a more descriptive name,
but an effort was made to try and explain what timeoutMs is everywhere that it
is used.
VOTE +1
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.7 (non-breaking only)
3.8-dev -> 3.8.2 (non-breaking only)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
