GumpacG commented on code in PR #3673:
URL: https://github.com/apache/tinkerpop/pull/3673#discussion_r4075168321
##########
gremlin-go/driver/traversal.go:
##########
@@ -905,3 +905,6 @@ func ParseBigInt(strValue string) *big.Int {
type ByteBuffer struct {
Data []byte
}
+
+// Rune represents the GraphBinary/Gremlin Character type.
+type Rune rune
Review Comment:
I think we should consider naming this `type Char rune`. This way users
would call `g.Inject(gremlingo.Char('a'))` instead of
`g.Inject(gremlingo.Rune('a'))`. The package already names this Gremlin type
GType.Char and the internals here are already char-based (charType, charWriter,
readChar), so Char would keep the naming consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
