GumpacG commented on code in PR #3673: URL: https://github.com/apache/tinkerpop/pull/3673#discussion_r4077484365
########## CHANGELOG.asciidoc: ########## @@ -25,6 +25,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima [[release-4-0-0]] === TinkerPop 4.0.0 (Release Date: NOT OFFICIALLY RELEASED YET) +* Added a `Char` type to `gremlin-go` to represent the Gremlin `Character` type in `GremlinLang` text generation and GraphBinary serialization, since Go's `rune` is only an alias for `int32` and cannot be distinguished from it. The `GoTranslateVisitor` now translates `Character` literals instead of raising an error, and the `@DataChar` feature scenarios are enabled for `gremlin-go`. Review Comment: This is too detailed. The entry can just be ```suggestion * Added a `Char` type to `gremlin-go` to represent the Gremlin `Character` type in `GremlinLang`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
