bitflicker64 commented on PR #3672: URL: https://github.com/apache/tinkerpop/pull/3672#issuecomment-5851089407
Started porting this to master and hit something worth flagging first. The port was easy: same `IntIO` bug in `graphbinaryV4.py`, same fix. But when I went to write a reproducer for the PR description, mine didn't fail. On master, `client.submit` turns the parameters dict into GremlinLang text (`['x':3000000000]`) before serialization, and the server's grammar reads that as a Long. Traversal args work the same way. So the failure that sent me here, a JanusGraph load passing server-assigned ids back as bindings, doesn't happen on master. The old code is still reachable through request options: `batchSize=3000000000` still raises `struct.error` on current master. The original failure is still present on 3.7.x and 3.8.x, and `3.8-dev` has the same unfixed `IntIO`. Would 3.8-dev work, merging forward to master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
