update JavaDoc to the ones I could
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/4c643f7b Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/4c643f7b Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/4c643f7b Branch: refs/heads/master Commit: 4c643f7b565c0c077258cc163804973e4f9c6d52 Parents: 6450b2b Author: Hayri Cicek <[email protected]> Authored: Mon Dec 10 20:06:30 2018 +0100 Committer: Hayri Cicek <[email protected]> Committed: Mon Dec 10 20:06:30 2018 +0100 ---------------------------------------------------------------------- .../openejb/loader/BasicURLClassPath.java | 23 +-- .../org/apache/openejb/loader/ClassPath.java | 8 +- .../apache/openejb/loader/ClassPathFactory.java | 5 - .../apache/openejb/loader/ContextClassPath.java | 6 +- .../org/apache/openejb/loader/FileUtils.java | 47 +++--- .../java/org/apache/openejb/loader/Files.java | 90 ++++++------ .../main/java/org/apache/openejb/loader/IO.java | 146 ++++++++++--------- .../org/apache/openejb/loader/JarLocation.java | 20 +-- .../java/org/apache/openejb/loader/Loader.java | 5 - .../openejb/loader/LoaderRuntimeException.java | 9 -- .../apache/openejb/loader/OpenEJBInstance.java | 7 +- .../java/org/apache/openejb/loader/Options.java | 142 +----------------- .../apache/openejb/loader/ProvisioningUtil.java | 10 -- .../apache/openejb/loader/SystemInstance.java | 27 ++-- .../apache/openejb/loader/TomcatClassPath.java | 9 -- .../apache/openejb/loader/WebAppClassPath.java | 4 - .../java/org/apache/openejb/loader/Zips.java | 9 +- .../openejb/loader/event/ComponentAdded.java | 5 - .../openejb/loader/event/ComponentRemoved.java | 5 - .../loader/provisining/HttpResolver.java | 5 - .../loader/provisining/MavenResolver.java | 10 -- .../provisining/ProvisiningResolverCreated.java | 9 -- .../provisining/ProvisioningResolver.java | 17 +-- .../provisining/ProvisioningResolverAware.java | 4 - .../openejb/observer/ObserverManager.java | 40 +---- .../openejb/observer/event/ObserverAdded.java | 4 - .../openejb/observer/event/ObserverFailed.java | 7 - .../openejb/observer/event/ObserverRemoved.java | 4 - 28 files changed, 211 insertions(+), 466 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java index 4c5ba77..9e56c27 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java @@ -28,6 +28,11 @@ import java.util.Locale; public abstract class BasicURLClassPath implements ClassPath { + /** + * Returns the context ClassLoader for this Thread or null + * + * @return ClassLoader ClassLoader + */ public static ClassLoader getContextClassLoader() { return AccessController.doPrivileged(new PrivilegedAction<ClassLoader>() { @Override @@ -41,7 +46,9 @@ public abstract class BasicURLClassPath implements ClassPath { private boolean ucpFieldErrorLogged; /** - * + * Add Jar to the URLClassPath + * + * Throws Exception if fails any * @param jar URL * @param loader URLClassLoader * @throws Exception @@ -75,7 +82,8 @@ public abstract class BasicURLClassPath implements ClassPath { } /** - * + * Adds Jars to the URLClassPath + * * @param dir File * @param loader URLClassLoader * @throws Exception @@ -125,7 +133,7 @@ public abstract class BasicURLClassPath implements ClassPath { } /** - * + * * @param loader URLClassLoader * @return Object * @throws Exception @@ -166,17 +174,14 @@ public abstract class BasicURLClassPath implements ClassPath { ClassLoader.registerAsParallelCapable(); } - /** - * - * @param parent ClassLoader - */ public CustomizableURLClassLoader(final ClassLoader parent) { super(new URL[0], parent); } /** - * - * @param url URL + * URLs to be added to the URL list for searching classes and resources + * + * @param url the URL to be added to the URLs list */ public void add(final URL url) { super.addURL(url); http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPath.java index 3baef29..4a12085 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPath.java @@ -24,14 +24,18 @@ public interface ClassPath { ClassLoader getClassLoader(); /** - * + * Add Jars to the URL ClassPath + * Throws Exception if it fails + * * @param dir File * @throws Exception */ void addJarsToPath(File dir) throws Exception; /** - * + * Add Jar to the URL ClassPath + * Throws Exception if it fails + * * @param dir URL * @throws Exception */ http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java index 4201bab..86b12f8 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java @@ -22,11 +22,6 @@ import static java.lang.ClassLoader.getSystemClassLoader; public class ClassPathFactory { - /** - * - * @param name String - * @return ClassPath - */ @SuppressWarnings("checkstyle:needbraces") public static ClassPath createClassPath(final String name) { if (name.equalsIgnoreCase("tomcat")) return new TomcatClassPath(); http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ContextClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ContextClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ContextClassPath.java index fe92b6f..320a02e 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ContextClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ContextClassPath.java @@ -36,7 +36,8 @@ public class ContextClassPath extends BasicURLClassPath { } /** - * + * Add Jars to URLClassPath + * * @param dir File * @throws Exception */ @@ -50,7 +51,8 @@ public class ContextClassPath extends BasicURLClassPath { } /** - * + * Add Jar to URLClassPath + * * @param jar URL * @throws Exception */ http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java index f6f15cd..c182b8e 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java @@ -31,12 +31,6 @@ public class FileUtils { this(homeDir, defaultDir, SystemInstance.get().getProperties()); } - /** - * - * @param homeDir String - * @param defaultDir String - * @param env Hashtable - */ @SuppressWarnings("UseOfObsoleteCollectionType") public FileUtils(final String homeDir, final String defaultDir, final Hashtable env) { @@ -65,10 +59,12 @@ public class FileUtils { } /** - * + * Returns the cannonical pathname + * + * * @param path String * @return File - * @throws IOException + * @throws IOException if an I/O error occurs */ public File getDirectory(final String path) throws IOException { return getDirectory(path, false); @@ -84,11 +80,12 @@ public class FileUtils { } /** - * + * Returns canonical form of the specified path + * * @param path String - * @param create boolean + * @param create boolean * @return File - * @throws IOException + * @throws IOException if an I/O error occurs */ public File getDirectory(final String path, final boolean create) throws IOException { File dir = new File(home, path); @@ -114,16 +111,13 @@ public class FileUtils { return home; } - /** - * - * @param dir File - */ public void setDirectory(final File dir) { this.home = dir; } /** - * + * Returns File at specified path String + * * @param path String * @return File * @throws IOException @@ -133,11 +127,12 @@ public class FileUtils { } /** - * + * Returns File at specified path String + * * @param path String * @param validate boolean * @return File - * @throws IOException + * @throws IOException if and I/O error occurs */ public File getFile(final String path, final boolean validate) throws IOException { File file = new File(path); @@ -156,9 +151,12 @@ public class FileUtils { } /** - * - * @param pathPrefix String - * @return File + * Creates Temp Directory + * + * Throws IOException if directory doesn't exists and if it fails to create directories + * + * @param pathPrefix path prefix + * @return File File * @throws IOException */ public static File createTempDirectory(final String pathPrefix) throws IOException { @@ -175,8 +173,11 @@ public class FileUtils { } /** - * - * @return File + * Creates Temp Directory + * + * Throws IOException if directory doesn't exists and if it fails to create directories + * + * @return File File * @throws IOException */ public static File createTempDirectory() throws IOException { http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java index 1b6d86f..6b247ec 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java @@ -47,7 +47,8 @@ public class Files { private static final boolean IS_WINDOWS = System.getProperty("os.name", "unknown").toLowerCase(Locale.ENGLISH).startsWith("win"); /** - * + * Returns the absolute path of the File Object + * * @param parts String... * @return File */ @@ -65,7 +66,8 @@ public class Files { } /** - * + * Returns the absolute path of the File Object + * * @param dir File * @param parts String... * @return File @@ -89,7 +91,8 @@ public class Files { } /** - * + * Returns a List of pathnames for File Objects + * * @param dir File * @param regex String * @return List of Files @@ -99,7 +102,8 @@ public class Files { } /** - * + * Returns a List of pathnames for File Objects + * * @param dir File * @param pattern Pattern * @return List of Files @@ -109,7 +113,8 @@ public class Files { } /** - * + * Returns a List of pathnames for File Objects + * * @param dir File * @param filter FileFilter * @return List of Files @@ -131,7 +136,8 @@ public class Files { } /** - * + * Method to check if the file or direcotory exists + * * @param file File * @param s String * @return File @@ -145,7 +151,8 @@ public class Files { } /** - * + * Method to check if the file or direcotory exists + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -158,7 +165,8 @@ public class Files { } /** - * + * Method to check if it is a directory + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -172,10 +180,11 @@ public class Files { } /** - * + * Method to create a file + * * @param file File * @return File - * @throws IOException + * @throws IOException if an I/O error occurs * @Throws FileRuntimeException on failure at any point */ public static File touch(final File file) throws IOException { @@ -186,7 +195,8 @@ public class Files { } /** - * + * Method to check if the specified File Object is a File + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -200,7 +210,8 @@ public class Files { } /** - * + * Method to check if File Object is hidden + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -214,7 +225,8 @@ public class Files { } /** - * + * Method to check if File Object is writeable + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -227,7 +239,8 @@ public class Files { } /** - * + * Method to check if File Object is readable + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -240,7 +253,8 @@ public class Files { } /** - * + * File Object is readble + * * @param file File * @return File */ @@ -249,10 +263,11 @@ public class Files { } /** - * + * Create directory by the specified path + * * @param file File * @return File - * @Throws FileRuntimeException on failure at any point + * @Throws FileRuntimeException if it fails to create directory */ public static File mkdir(final File file) { if (file.exists()) { @@ -275,7 +290,8 @@ public class Files { } /** - * + * Create directory by the specified parent pathname and child pathname + * * @param file file * @param name String * @return File @@ -285,9 +301,10 @@ public class Files { } /** - * + * Method to create tmp directory + * * @return File - * @Throws IOException on failure at any point + * @Throws IOException if an I/O error occurs */ public static File tmpdir() { try { @@ -324,9 +341,10 @@ public class Files { } /** - * + * Create parent pathname by the specified pathname + * * @param file File - * @return File + * @return File */ public static File mkparent(final File file) { mkdirs(file.getParentFile()); @@ -334,7 +352,8 @@ public class Files { } /** - * + * Create directories by the specified pathname + * * @param file File * @return File * @Throws FileRuntimeException on failure at any point @@ -375,7 +394,8 @@ public class Files { } /** - * + * Delete File Object when exit + * * @param file File */ public static void deleteOnExit(final File file) { @@ -384,7 +404,8 @@ public class Files { } /** - * + * Delete File Objects when exit + * * @param file File */ public static void flagForDeleteOnExit(final File file) { @@ -469,13 +490,6 @@ public class Files { } } - /** - * - * @param dir File - * @param pattern String - * @return File - * @Throws IllegalStateException on failure at any point - */ public static File select(final File dir, final String pattern) { final List<File> matches = collect(dir, pattern); if (matches.isEmpty()) { @@ -554,12 +568,6 @@ public class Files { return set; } - /** - * - * @param url URL - * @return File - * @Throws IllegalStateException on failure at any point - */ public static File toFile(final URL url) { if ("jar".equals(url.getProtocol())) { try { @@ -588,12 +596,6 @@ public class Files { } } - /** - * - * @param urls Set<URL> - * @param algo String - * @return String - */ public static String hash(final Set<URL> urls, final String algo) { final Collection<File> files = new ArrayList<>(); http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/IO.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/IO.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/IO.java index e73f2b5..481d03c 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/IO.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/IO.java @@ -69,10 +69,11 @@ public class IO { } /** - * + * Method for reading files as String + * * @param uri URI * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String readFileAsString(final URI uri) throws IOException { final StringBuilder builder = new StringBuilder(""); @@ -102,42 +103,46 @@ public class IO { } /** - * + * Method for reading Properties + * * @param resource URL * @return Properties - * @throws IOException + * @throws IOException if an I/O error occurs */ public static Properties readProperties(final URL resource) throws IOException { return readProperties(resource, new Properties()); } /** - * + * Reading Properties + * * @param resource URL * @param properties Properties * @return Properties - * @throws IOException + * @throws IOException if and I/O error occurs */ public static Properties readProperties(final URL resource, final Properties properties) throws IOException { return readProperties(read(resource), properties); } /** - * + * Read properties of the specified pathname + * * @param resource File * @return Properties - * @throws IOException + * @throws IOException if an I/O error occurs */ public static Properties readProperties(final File resource) throws IOException { return readProperties(resource, new Properties()); } /** - * + * Read properties of the specified pathname + * * @param resource File * @param properties Properties * @return Properties - * @throws IOException + * @throws IOException if an I/O error occurs */ public static Properties readProperties(final File resource, final Properties properties) throws IOException { return readProperties(read(resource), properties); @@ -167,10 +172,11 @@ public class IO { } /** - * + * Method for reading the String of the specified pathname + * * @param url URL * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String readString(final URL url) throws IOException { final InputStream in = url.openStream(); @@ -183,10 +189,11 @@ public class IO { } /** - * + * Method for reading the String of the specified pathname + * * @param file File * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String readString(final File file) throws IOException { final FileReader in = new FileReader(file); @@ -199,10 +206,11 @@ public class IO { } /** - * + * Method to read the entire File into a String + * * @param file File * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String slurp(final File file) throws IOException { try (final InputStream is = read(file)) { @@ -211,20 +219,22 @@ public class IO { } /** - * + * Method to read the entire specified pathname into a String + * * @param url URL * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String slurp(final URL url) throws IOException { return slurp(url.openStream()); } /** - * + * Method to read the entire InputStream into a String + * * @param in InputStream * @return String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static String slurp(final InputStream in) throws IOException { final ByteArrayOutputStream out = new ByteArrayOutputStream(); @@ -233,10 +243,11 @@ public class IO { } /** - * + * Method to write the specified String to File + * * @param file File * @param string String - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void writeString(final File file, final String string) throws IOException { final FileWriter out = new FileWriter(file); @@ -254,10 +265,11 @@ public class IO { } /** - * + * Method to copy File object + * * @param from File * @param to File - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copy(final File from, final File to) throws IOException { if (!from.isDirectory()) { @@ -273,10 +285,11 @@ public class IO { } /** - * + * Method to copy directory + * * @param srcDir File * @param destDir File - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copyDirectory(final File srcDir, final File destDir) throws IOException { if (srcDir == null) { @@ -340,10 +353,11 @@ public class IO { } /** - * + * Method to copy File to OutputStream + * * @param from File * @param to OutputStream - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copy(final File from, final OutputStream to) throws IOException { final InputStream read = read(from); @@ -355,10 +369,11 @@ public class IO { } /** - * + * Method to copy from specified pathname to OutputStream + * * @param from URL * @param to OutputStream - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copy(final URL from, final OutputStream to) throws IOException { final InputStream read = read(from); @@ -370,10 +385,11 @@ public class IO { } /** - * + * Method to copy from InputStream to File + * * @param from InputStream * @param to File - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copy(final InputStream from, final File to) throws IOException { final OutputStream write = write(to); @@ -385,11 +401,12 @@ public class IO { } /** - * + * Method to copy InputStream to File and append + * * @param from InputStream * @param to File * @param append boolean - * @throws IOException + * @throws IOException if an I/O error occurs */ public static void copy(final InputStream from, final File to, final boolean append) throws IOException { final OutputStream write = write(to, append); @@ -400,12 +417,6 @@ public class IO { } } - /** - * - * @param from InputStream - * @param to OutputStream - * @throws IOException - */ public static void copy(final InputStream from, final OutputStream to) throws IOException { final byte[] buffer = new byte[1024]; int length; @@ -415,31 +426,20 @@ public class IO { to.flush(); } - /** - * - * @param from byte[] - * @param to File - * @throws IOException - */ public static void copy(final byte[] from, final File to) throws IOException { copy(new ByteArrayInputStream(from), to); } - /** - * - * @param from byte[] - * @param to OutputStream - * @throws IOException - */ public static void copy(final byte[] from, final OutputStream to) throws IOException { copy(new ByteArrayInputStream(from), to); } /** - * + * Method for writing specified File as ZIP file format + * * @param file File - * @return ZipOutputStream - * @throws IOException + * @return ZipOutputStream ZipOutputStream + * @throws IOException if an I/O error occurs */ public static ZipOutputStream zip(final File file) throws IOException { final OutputStream write = write(file); @@ -447,10 +447,11 @@ public class IO { } /** - * + * Method to unzip ZIP file + * * @param file File * @return ZipInputStream - * @throws IOException + * @throws IOException if an I/O error occurs */ public static ZipInputStream unzip(final File file) throws IOException { final InputStream read = read(file); @@ -480,9 +481,10 @@ public class IO { } /** - * + * Delete file + * * @param file File - * @return boolean + * @return boolean if file successfully deleted */ public static boolean delete(final File file) { if (file == null) { @@ -497,10 +499,11 @@ public class IO { } /** - * + * Write data to the specified File destination + * * @param destination File * @return OutputStream - * @throws FileNotFoundException + * @throws FileNotFoundException if the file is not found */ public static OutputStream write(final File destination) throws FileNotFoundException { final OutputStream out = new FileOutputStream(destination); @@ -508,11 +511,12 @@ public class IO { } /** - * + * Write data to the specified File destination and append + * * @param destination File * @param append boolean * @return OutputStream - * @throws FileNotFoundException + * @throws FileNotFoundException if the file is not found */ public static OutputStream write(final File destination, final boolean append) throws FileNotFoundException { final OutputStream out = new FileOutputStream(destination, append); @@ -520,10 +524,11 @@ public class IO { } /** - * + * Read data from the specified File source + * * @param source File * @return InputStream - * @throws FileNotFoundException + * @throws FileNotFoundException if the file is not found */ public static InputStream read(final File source) throws FileNotFoundException { final InputStream in = new FileInputStream(source); @@ -531,7 +536,8 @@ public class IO { } /** - * + * Read the next byte from the specified String to input stream + * * @param content String * @return InputStream */ @@ -540,7 +546,8 @@ public class IO { } /** - * + * Read the next byte from the specified String to input stream using encoding + * * @param content String * @param encoding String * @return InputStream @@ -551,7 +558,8 @@ public class IO { } /** - * + * Read the data from byte array + * * @param content byte[] * @return InputStream */ @@ -560,7 +568,7 @@ public class IO { } /** - * + * Open connection to the specified URL and return InputStream for reading from the connection * @param url URL * @return InputStream * @throws IOException http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java index 2d274cf..dba00e8 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java @@ -31,7 +31,8 @@ public class JarLocation { } /** - * + * Return jar from the specified resource name + * * @param resourceName String * @return File */ @@ -40,7 +41,8 @@ public class JarLocation { } /** - * + * Return jar from the specified resource name + * * @param loader ClassLoader * @param resourceName String * @return File @@ -80,7 +82,8 @@ public class JarLocation { } /** - * + * Return jar location + * * @param clazz Class * @return File */ @@ -96,23 +99,12 @@ public class JarLocation { } } - /** - * - * @param classFileName String - * @param url URL - * @return File - */ public static File toFile(final String classFileName, final URL url) { String path = url.getFile(); path = path.substring(0, path.length() - classFileName.length()); return new File(decode(path)); } - /** - * - * @param fileName String - * @return String - */ public static String decode(final String fileName) { if (fileName.indexOf('%') == -1) { return fileName; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Loader.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Loader.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Loader.java index 635f30b..2ebadbb 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Loader.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Loader.java @@ -20,11 +20,6 @@ import java.util.Properties; public interface Loader { - /** - * - * @param properties Properties - * @throws Exception - */ void init(Properties properties) throws Exception; } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/LoaderRuntimeException.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/LoaderRuntimeException.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/LoaderRuntimeException.java index b9fc239..cfe3ab0 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/LoaderRuntimeException.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/LoaderRuntimeException.java @@ -18,19 +18,10 @@ package org.apache.openejb.loader; public class LoaderRuntimeException extends RuntimeException { - /** - * - * @param str String - * @param e Throwable - */ public LoaderRuntimeException(final String str, final Throwable e) { super(str, e); } - /** - * - * @param e Exception - */ public LoaderRuntimeException(final Exception e) { super(e); } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/OpenEJBInstance.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/OpenEJBInstance.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/OpenEJBInstance.java index d352a66..69f7166 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/OpenEJBInstance.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/OpenEJBInstance.java @@ -30,12 +30,7 @@ public class OpenEJBInstance { this.init = openejb.getMethod("init", Properties.class); this.isInitialized = openejb.getMethod("isInitialized"); } - - /** - * - * @param props Properties - * @throws Exception - */ + public void init(final Properties props) throws Exception { try { init.invoke(null, props); http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Options.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Options.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Options.java index 9d0b9cd..96bb761 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Options.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Options.java @@ -73,34 +73,21 @@ public class Options { private final Options parent; private final TomEEPropertyAdapter properties; - /** - * - * @param properties Properties - */ public Options(final Properties properties) { this(properties, new NullOptions()); } - /** - * - * @param properties Properties - * @param parent Options - */ public Options(final Properties properties, final Options parent) { this.parent = parent; this.properties = new TomEEPropertyAdapter(properties); } - /** - * - * @return Properties - */ public Properties getProperties() { return properties.delegate; } /** - * + * * @param logger Log */ public void setLogger(final Log logger) { @@ -116,7 +103,8 @@ public class Options { } /** - * + * Method to check if properties contains the specified String property + * * @param property String * @return boolean */ @@ -125,7 +113,8 @@ public class Options { } /** - * + * Return property by the specified String property + * * @param property String * @param defaultValue String * @return String @@ -136,13 +125,6 @@ public class Options { return value != null ? log(property, value) : parent.get(property, defaultValue); } - /** - * - * @param <T> - * @param property String - * @param defaultValue T - * @return - */ @SuppressWarnings("unchecked") public <T> T get(final String property, final T defaultValue) { if (defaultValue == null) { @@ -167,12 +149,6 @@ public class Options { } } - /** - * - * @param property String - * @param defaultValue int - * @return int - */ public int get(final String property, final int defaultValue) { final String value = properties.getProperty(property); @@ -188,12 +164,6 @@ public class Options { } } - /** - * - * @param property String - * @param defaultValue long - * @return long - */ public long get(final String property, final long defaultValue) { final String value = properties.getProperty(property); @@ -209,12 +179,6 @@ public class Options { } } - /** - * - * @param property String - * @param defaultValue boolean - * @return boolean - */ public boolean get(final String property, final boolean defaultValue) { final String value = properties.getProperty(property); @@ -230,12 +194,6 @@ public class Options { } } - /** - * - * @param property String - * @param defaultValue - * @return - */ public Class<?> get(final String property, final Class<?> defaultValue) { final String className = properties.getProperty(property); @@ -252,13 +210,6 @@ public class Options { } } - /** - * - * @param <T> - * @param property String - * @param defaultValue - * @return - */ public <T extends Enum<T>> T get(final String property, final T defaultValue) { final String value = properties.getProperty(property); @@ -280,25 +231,11 @@ public class Options { } } - /** - * - * @param <T> - * @param property String - * @param defaultValue T... - * @return - */ public <T extends Enum<T>> Set<T> getAll(final String property, final T... defaultValue) { final EnumSet<T> defaults = EnumSet.copyOf(Arrays.asList(defaultValue)); return getAll(property, defaults); } - /** - * - * @param <T> - * @param property String - * @param defaultValue - * @return - */ public <T extends Enum<T>> Set<T> getAll(final String property, final Set<T> defaultValue) { final Class<T> enumType; try { @@ -311,13 +248,6 @@ public class Options { return getAll(property, defaultValue, enumType); } - /** - * - * @param <T> - * @param property String - * @param enumType - * @return - */ public <T extends Enum<T>> Set<T> getAll(final String property, final Class<T> enumType) { return getAll(property, Collections.EMPTY_SET, enumType); } @@ -401,13 +331,6 @@ public class Options { return value; } - /** - * - * @param <T> - * @param property String - * @param value - * @return - */ public <T extends Enum<T>> Set<T> logAll(final String property, final Set<T> value) { if (!getLogger().isInfoEnabled()) { return value; @@ -418,12 +341,6 @@ public class Options { return value; } - /** - * - * @param <T> - * @param items - * @return - */ protected static <T extends Enum<T>> String[] lowercase(final T... items) { final String[] values = new String[items.length]; for (int i = 0; i < items.length; i++) { @@ -432,12 +349,6 @@ public class Options { return values; } - /** - * - * @param <T> - * @param items - * @return - */ protected static <T extends Enum<T>> String[] lowercase(final Collection<T> items) { final String[] values = new String[items.size()]; int i = 0; @@ -447,12 +358,6 @@ public class Options { return values; } - /** - * - * @param <V> - * @param v - * @return - */ protected static <V extends Enum<V>> String possibleValues(final V v) { final Class<? extends Enum> enumType = v.getClass(); return possibleValues(enumType); @@ -594,19 +499,10 @@ public class Options { public static final int OPENEJB_PREFIX_LENGHT = "openejb.".length(); private final Properties delegate; - /** - * - * @param properties Properties - */ public TomEEPropertyAdapter(final Properties properties) { this.delegate = properties; } - /** - * - * @param key String - * @return String - */ public String getProperty(final String key) { String value = delegate.getProperty(key); @@ -617,11 +513,6 @@ public class Options { return value; } - /** - * - * @param key String - * @return boolean - */ public boolean containsKey(final String key) { return delegate.containsKey(key) || delegate.containsKey(getTomeeKey(key)); @@ -669,45 +560,22 @@ public class Options { return false; } - /** - * - * @param message String - * @param t Throwable - */ @Override public void warning(final String message, final Throwable t) { } - /** - * - * @param message String - */ @Override public void warning(final String message) { } - /** - * - * @param message String - * @param t Throwable - */ @Override public void debug(final String message, final Throwable t) { } - /** - * - * @param message String - */ @Override public void debug(final String message) { } - /** - * - * @param message String - * @param t Throwable - */ @Override public void info(final String message, final Throwable t) { } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ProvisioningUtil.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ProvisioningUtil.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ProvisioningUtil.java index b1d20aa..f7540ca 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/ProvisioningUtil.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/ProvisioningUtil.java @@ -43,11 +43,6 @@ public final class ProvisioningUtil { // no-op } - /** - * - * @return - * @throws IOException - */ public static Collection<File> addAdditionalLibraries() throws IOException { final File conf = SystemInstance.get().getConf(ADDITIONAL_LIB_CONFIG); if (conf == null || !conf.exists()) { @@ -148,11 +143,6 @@ public final class ProvisioningUtil { return libs; } - /** - * - * @param location String - * @return - */ public static Set<String> realLocation(final String location) { final boolean initialized = SystemInstance.isInitialized(); if (!initialized) { http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java index 70a5e01..609119a 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java @@ -130,18 +130,13 @@ public final class SystemInstance { System.setProperty("derby.system.home", System.getProperty("derby.system.home", baseDirCanonicalPath)); } - /** - * - * @param <E> - * @param event - * @return - */ public <E> E fireEvent(final E event) { return observerManager.fireEvent(event); } /** - * + * Add the specified Object to Observer + * * @param observer Object * @return boolean */ @@ -150,7 +145,8 @@ public final class SystemInstance { } /** - * + * Remove the specified Object from Observer + * * @param observer Object * @return boolean */ @@ -172,7 +168,8 @@ public final class SystemInstance { } /** - * + * Return the property by the specified String key + * * @param key String * @return String */ @@ -181,7 +178,9 @@ public final class SystemInstance { } /** - * + * Return the property by the specified String key + * if the key is not found the default value will be returned + * * @param key String * @param defaultValue String * @return String @@ -312,11 +311,6 @@ public final class SystemInstance { } } - /** - * - * @param properties Properties - * @throws Exception - */ public static synchronized void init(final Properties properties) throws Exception { if (initialized) { return; @@ -347,7 +341,8 @@ public final class SystemInstance { } /** - * + * Returns the conf by the specified pathname + * * @param subPath String * @return File */ http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/TomcatClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/TomcatClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/TomcatClassPath.java index 5869814..428c248 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/TomcatClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/TomcatClassPath.java @@ -48,10 +48,6 @@ public class TomcatClassPath extends BasicURLClassPath { this(getCommonLoader(getContextClassLoader())); } - /** - * - * @param classLoader ClassLoader - */ public TomcatClassPath(final ClassLoader classLoader) { this.commonLoader = classLoader; @@ -129,11 +125,6 @@ public class TomcatClassPath extends BasicURLClassPath { rebuild(); } - /** - * - * @param jar URL - * @throws Exception - */ public void _addJarToPath(final URL jar) throws Exception { ClassLoader classLoader = commonLoader; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/WebAppClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/WebAppClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/WebAppClassPath.java index 1b45361..94da85e 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/WebAppClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/WebAppClassPath.java @@ -22,10 +22,6 @@ public class WebAppClassPath extends TomcatClassPath { this(getContextClassLoader()); } - /** - * - * @param classLoader ClassLoader - */ public WebAppClassPath(final ClassLoader classLoader) { super(classLoader); } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Zips.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Zips.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Zips.java index 6b52322..3893549 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/Zips.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/Zips.java @@ -28,7 +28,8 @@ import java.util.zip.ZipInputStream; public class Zips { /** - * + * Unzip the specified ZIP file to the specified destination + * * @param zipFile File * @param destination File * @throws IOException @@ -38,7 +39,8 @@ public class Zips { } /** - * + * Unzip the specified ZIP file to the specified destination + * * @param zipFile File * @param destination File * @param noparent boolean @@ -61,7 +63,8 @@ public class Zips { } /** - * + * Method to unzip ZIP files + * * @param read InputStream * @param destination File * @param noparent boolean http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentAdded.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentAdded.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentAdded.java index acb91fc..5370107 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentAdded.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentAdded.java @@ -27,11 +27,6 @@ public class ComponentAdded<T> { private final Class<T> type; private final T component; - /** - * - * @param type - * @param component - */ public ComponentAdded(final Class<T> type, final T component) { this.type = type; this.component = component; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentRemoved.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentRemoved.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentRemoved.java index f5a1724..095aece 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentRemoved.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/event/ComponentRemoved.java @@ -27,11 +27,6 @@ public class ComponentRemoved<T> { private final Class<T> type; private final T component; - /** - * - * @param type - * @param component - */ public ComponentRemoved(final Class<T> type, final T component) { this.type = type; this.component = component; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java index 34d625f..db8139f 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java @@ -57,11 +57,6 @@ public class HttpResolver implements ArchiveResolver { return lastPart(rawLocation.replace(':', '/')); } - /** - * - * @param location String - * @return String - */ public static String lastPart(final String location) { int idx = location.lastIndexOf('/'); if (idx <= 0) { http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java index e753b4f..2f8c60d 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java @@ -93,12 +93,6 @@ public class MavenResolver implements ArchiveResolver, ProvisioningResolverAware return Objects.requireNonNull(SystemInstance.get().getComponent(ProvisioningResolver.class)).resolveStream(repo1Url); } - /** - * - * @param raw String - * @return String - * @throws MalformedURLException - */ public String quickMvnUrl(final String raw) throws MalformedURLException { final String base; if (raw.contains(SNAPSHOT_SUFFIX) && raw.contains("apache")) { @@ -295,10 +289,6 @@ public class MavenResolver implements ArchiveResolver, ProvisioningResolverAware return defaultVersion; } - /** - * - * @param resolver ProvisioningResolver - */ @Override public void setResolver(final ProvisioningResolver resolver) { this.resolver = resolver; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisiningResolverCreated.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisiningResolverCreated.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisiningResolverCreated.java index 421f887..fbdc767 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisiningResolverCreated.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisiningResolverCreated.java @@ -22,19 +22,10 @@ import org.apache.openejb.observer.Event; public class ProvisiningResolverCreated { private final ProvisioningResolver resolver; - /** - * - * @param provisioningResolver ProvisioningResolver - */ public ProvisiningResolverCreated(final ProvisioningResolver provisioningResolver) { resolver = provisioningResolver; } - /** - * - * @param resolver ArchiveResolver - * @return ProvisiningResolverCreated - */ public ProvisiningResolverCreated register(final ArchiveResolver resolver) { this.resolver.addResolver(resolver); return this; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolver.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolver.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolver.java index ebe8dff..4bbe082 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolver.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolver.java @@ -75,7 +75,8 @@ public class ProvisioningResolver { } /** - * + * Add ArchiveResolver to resolvers + * * @param resolver ArchiveResolver */ public void addResolver(final ArchiveResolver resolver) { @@ -85,7 +86,8 @@ public class ProvisioningResolver { } /** - * + * Remove ArchiveResolver + * * @param resolver ArchiveResolver */ public void removeResolver(final ArchiveResolver resolver) { @@ -93,7 +95,8 @@ public class ProvisioningResolver { } /** - * + * Real path location of the specified location + * * @param rawLocation String * @return */ @@ -171,12 +174,6 @@ public class ProvisioningResolver { } } - /** - * - * @param rawLocation String - * @return InputStream - * @throws MalformedURLException - */ public InputStream resolveStream(final String rawLocation) throws MalformedURLException { final File file = new File(rawLocation); if (file.exists()) { @@ -196,7 +193,7 @@ public class ProvisioningResolver { } /** - * + * Cache the specified String pathname * @param path String * @return File */ http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolverAware.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolverAware.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolverAware.java index 7fc4dd3..1158718 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolverAware.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/ProvisioningResolverAware.java @@ -22,9 +22,5 @@ package org.apache.openejb.loader.provisining; // ex: mvn delegates to http if the archive is not found locally public interface ProvisioningResolverAware { - /** - * - * @param resolver ProvisioningResolver - */ void setResolver(ProvisioningResolver resolver); } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java b/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java index 53fb577..29a44be 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java @@ -56,7 +56,8 @@ public class ObserverManager { private final Map<Class, Invocation> methods = new ConcurrentHashMap<>(); /** - * + * Add Object to Observer + * * @param observer Object * @return boolean */ @@ -80,7 +81,8 @@ public class ObserverManager { } /** - * + * Remove Object from Observer + * * @param observer Object * @return boolean */ @@ -321,30 +323,14 @@ public class ObserverManager { } } - /** - * - * @param event Phase - * @param eventType Class - * @return Invocation - */ public Invocation get(final Phase event, final Class eventType) { return get(map(event), eventType); } - /** - * - * @param eventType Class - * @return Invocation - */ public Invocation getAfter(final Class eventType) { return get(after, eventType); } - /** - * - * @param eventType Class - * @return - */ public Invocation getBefore(final Class eventType) { return get(before, eventType); } @@ -417,20 +403,11 @@ public class ObserverManager { private final Method method; private final Object observer; - /** - * - * @param method Method - * @param observer Object - */ public MethodInvocation(final Method method, final Object observer) { this.method = method; this.observer = observer; } - /** - * - * @param event Object - */ @Override public void invoke(final Object event) { try { @@ -540,11 +517,6 @@ public class ObserverManager { private final List<Invocation> invocations = new LinkedList<>(); - /** - * - * @param invocation Invocation - * @return boolean - */ public boolean add(final Invocation invocation) { return invocations.add(invocation); } @@ -553,10 +525,6 @@ public class ObserverManager { return invocations; } - /** - * - * @param event Object - */ @Override public void invoke(final Object event) { for (final Invocation invocation : invocations) { http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java index 361ee0a..87dbd74 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java @@ -26,10 +26,6 @@ public class ObserverAdded { private final Object observer; - /** - * - * @param observer Object - */ public ObserverAdded(final Object observer) { this.observer = observer; } http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverFailed.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverFailed.java b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverFailed.java index 9d27b68..83beb49 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverFailed.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverFailed.java @@ -34,13 +34,6 @@ public class ObserverFailed { private final Throwable throwable; - /** - * - * @param observer Object - * @param method Method - * @param event Object - * @param throwable Throwable - */ public ObserverFailed(final Object observer, final Method method, final Object event, final Throwable throwable) { this.observer = observer; this.event = event; http://git-wip-us.apache.org/repos/asf/tomee/blob/4c643f7b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java index a685757..f33efa3 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java @@ -26,10 +26,6 @@ public class ObserverRemoved { private final Object observer; - /** - * - * @param observer Object - */ public ObserverRemoved(final Object observer) { this.observer = observer; }
