ThreadLocalRandom, use diamond op
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/cdb9e444 Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/cdb9e444 Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/cdb9e444 Branch: refs/heads/master Commit: cdb9e4445d91da8bb18df5aa39141984ac0d4aa0 Parents: d815cee Author: Hayri Cicek <[email protected]> Authored: Fri Dec 7 22:54:29 2018 +0100 Committer: Hayri Cicek <[email protected]> Committed: Fri Dec 7 22:54:29 2018 +0100 ---------------------------------------------------------------------- .../java/org/apache/openejb/loader/BasicURLClassPath.java | 4 ---- .../src/main/java/org/apache/openejb/loader/FileUtils.java | 9 +++------ .../main/java/org/apache/openejb/loader/SystemInstance.java | 2 +- 3 files changed, 4 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tomee/blob/cdb9e444/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java index b9bf5df..4c5ba77 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java @@ -28,10 +28,6 @@ import java.util.Locale; public abstract class BasicURLClassPath implements ClassPath { - /** - * - * @return ClassLoader - */ public static ClassLoader getContextClassLoader() { return AccessController.doPrivileged(new PrivilegedAction<ClassLoader>() { @Override http://git-wip-us.apache.org/repos/asf/tomee/blob/cdb9e444/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java index 6a5ea98..b9ef77f 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java @@ -20,11 +20,12 @@ import java.io.File; import java.io.FileNotFoundException; import java.io.IOException; import java.util.Hashtable; +import java.util.concurrent.ThreadLocalRandom; @SuppressWarnings("PMD.OverrideBothEqualsAndHashcode") public class FileUtils { - private static final java.util.Random RANDOM = new java.util.Random(); + private static final ThreadLocalRandom _random = ThreadLocalRandom.current(); private File home; @@ -111,10 +112,6 @@ public class FileUtils { return dir; } - /** - * - * @return File - */ public File getDirectory() { return home; } @@ -169,7 +166,7 @@ public class FileUtils { public static File createTempDirectory(final String pathPrefix) throws IOException { for (int maxAttempts = 100; maxAttempts > 0; --maxAttempts) { - final String path = pathPrefix + RANDOM.nextLong(); + final String path = pathPrefix + _random.nextLong(); final File tmpDir = new File(path); if (!tmpDir.exists() && tmpDir.mkdirs()) { http://git-wip-us.apache.org/repos/asf/tomee/blob/cdb9e444/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java ---------------------------------------------------------------------- diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java index 1b8725a..47baafc 100644 --- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java +++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java @@ -318,7 +318,7 @@ public final class SystemInstance { return removed; } - private static final AtomicReference<SystemInstance> SYSTEM = new AtomicReference<SystemInstance>(); + private static final AtomicReference<SystemInstance> SYSTEM = new AtomicReference<>(); static { reset();
